code-review · 스킬 지원 에이전트
Sentry의 코드 검토 기준으로 런타임 오류, 성능 문제와 빠진 테스트를 살펴봅니다.
동작은 하는 것 같지만 다른 부분에 영향을 줄까 걱정되는 코드 변경에 활용합니다. 바뀐 파일만 읽는 대신 주변 호출 흐름과 테스트를 연결해 검토하도록 안내하는 스킬입니다.
검토할 변경과 프로젝트 규칙을 알려주고 실제 오류 가능성이 있는 항목을 우선해 달라고 요청하세요. Sentry 팀의 기준을 그대로 가져오기보다 내 저장소의 규칙에 맞춰 조정해야 합니다. 정적 검토 결과와 직접 실행한 검증은 구분해서 확인합니다.
code-review로 이 변경을 검토해줘. 오류·성능·권한·테스트 누락을 중심으로 실제 근거가 있는 항목만 적고 재현이나 검증 방법을 함께 알려줘.
받을 수 있는 결과리뷰 의견과 확인할 문제
2026-10-05 격리 폴더에서 원문을 읽고 작은 코드 예제를 검토했습니다. 아래 배열 결과는 Node 검사로 확인했습니다. 에이전트의 자동 스킬 호출은 검증하지 않았습니다.
코드 리뷰를 요청할 때는 코드와 함께 기대하는 동작을 적는 편이 좋습니다. 이번 예제는 페이지 번호와 페이지 크기가 양의 정수라는 조건에서, 여섯 항목 중 첫 페이지에 세 항목이 나와야 했습니다. 조건이 없으면 코드가 짧아 보인다는 이유로 문제를 놓칠 수 있습니다.
// 입력: [1,2,3,4,5,6], page=1, size=3
return items.slice((page-1)*size, page*size-1);slice의 끝 위치는 결과에 포함되지 않습니다. 여기서 1을 더 빼면 첫 페이지의 마지막 항목도 빠집니다. 검토 결과는 막연한 개선 제안이 아니라 문제 위치, 발생 조건과 수정 방법으로 정리했습니다.
수정 전 첫 페이지: [1,2]
수정: items.slice((page-1)*size, page*size)
수정 후 첫 페이지: [1,2,3]
수정 후 두 번째 페이지: [4,5,6]이 결과는 작은 예제의 범위에서 확인한 것입니다. 실제 목록에는 빈 배열, 마지막 페이지와 잘못된 페이지 번호가 들어올 수 있습니다. 내 서비스가 각 경우를 어떻게 처리해야 하는지 먼저 정하고, 그 조건의 검사도 추가하세요. 리뷰가 끝났다는 말과 실제 실행 결과를 구분해 읽으면 도움이 됩니다.
스킬 지원 에이전트와 저장소 접근이 필요합니다. Sentry 팀 기준은 자신의 프로젝트 규칙에 맞춰 적용합니다.
현재 사용 중인 스킬 지원 에이전트에 아래 요청을 붙여넣으세요. SKILL.md만 복사하면 보조 파일이 빠질 수 있어요.
https://github.com/getsentry/skills 에서 skills/code-review 스킬을 현재 에이전트의 스킬 폴더에 설치해줘. SKILL.md와 이 스킬이 참조하는 scripts·references·assets와 공통 파일을 함께 유지하고, 필요한 실행 환경과 추가 연결을 확인한 뒤 알려줘. 설치가 끝나면 code-review 스킬을 인식하는지 확인해줘.
“code-review 스킬을 사용해줘. 입력 자료: 전체 변경 내용·관련 코드·테스트”처럼 요청하세요. 위의 예시를 내 자료에 맞게 바꿔도 좋아요.
예상 결과는 ‘리뷰 의견과 확인할 문제’입니다. 필요한 내용이 포함됐는지 확인하세요. 입력 자료의 사실·숫자와 결과를 대조하고, 부족한 부분을 이어서 요청하세요.
제작자 원본 2026-10-04 확인 · 설치 안내 2026-10-04 확인 · 격리 폴더 설치·샘플 검토 2026-10-05 확인 · 에이전트 자동 호출 미검증
모델 사용 요금과 연결 앱 요금은 이용 중인 서비스의 정책을 따릅니다.
설치 안내 출처--- name: code-review description: Perform code reviews following Sentry engineering practices. Use when reviewing pull requests, examining code changes, or providing feedback on code quality. Covers security, performance, testing, and design review. --- # Sentry Code Review Follow these guidelines when reviewing code for Sentry projects. ## Review Checklist ### Identifying Problems Look for these issues in code changes: - **Runtime errors**: Potential exceptions, null pointer issues, out-of-bounds access - **Performance**: Unbounded O(n²) operations, N+1 queries, unnecessary allocations - **Side effects**: Unintended behavioral changes affecting other components - **Backwards compatibility**: Breaking API changes without migration path - **ORM queries**: Complex Django ORM with unexpected query performance - **Security vulnerabilities**: Injection, XSS, access control gaps, secrets exposure ### Design Assessment - Do component interactions make logical sense?--- name: code-review description: Perform code reviews following Sentry engineering practices. Use when reviewing pull requests, examining code changes, or providing feedback on code quality. Covers security, performance, testing, and design review. --- # Sentry Code Review Follow these guidelines when reviewing code for Sentry projects. ## Review Checklist ### Identifying Problems Look for these issues in code changes: - **Runtime errors**: Potential exceptions, null pointer issues, out-of-bounds access - **Performance**: Unbounded O(n²) operations, N+1 queries, unnecessary allocations - **Side effects**: Unintended behavioral changes affecting other components - **Backwards compatibility**: Breaking API changes without migration path - **ORM queries**: Complex Django ORM with unexpected query performance - **Security vulnerabilities**: Injection, XSS, access control gaps, secrets exposure ### Design Assessment - Do component interactions make logical sense? - Does the change align with existing project architecture? - Are there conflicts with current requirements or goals? ### Test Coverage Every PR should have appropriate test coverage: - Functional tests for business logic - Integration tests for component interactions - End-to-end tests for critical user paths Verify tests cover actual requirements and edge cases. Avoid excessive branching or looping in test code. ### Long-Term Impact Flag for senior engineer review when changes involve: - Database schema modifications - API contract changes - New framework or library adoption - Performance-critical code paths - Security-sensitive functionality ## Feedback Guidelines ### Tone - Be polite and empathetic - Provide actionable suggestions, not vague criticism - Phrase as questions when uncertain: "Have you considered...?" ### Approval - Approve when only minor issues remain - Don't block PRs for stylistic preferences - Remember: the goal is risk reduction, not perfect code ## Common Patterns to Flag ### Python/Django ```python # Bad: N+1 query for user in users: print(user.profile.name) # Separate query per user # Good: Prefetch related users = User.objects.prefetch_related('profile') ``` ### TypeScript/React ```typescript // Bad: Missing dependency in useEffect useEffect(() => { fetchData(userId); }, []); // userId not in deps // Good: Include all dependencies useEffect(() => { fetchData(userId); }, [userId]); ``` ### Security ```python # Bad: SQL injection risk cursor.execute(f"SELECT * FROM users WHERE id = {user_id}") # Good: Parameterized query cursor.execute("SELECT * FROM users WHERE id = %s", [user_id]) ``` ## References - [Sentry Code Review Guidelines](https://develop.sentry.dev/engineering-practices/code-review/)
Original skill: getsentry/skills/skills/code-review/SKILL.md
Source: https://github.com/getsentry/skills/blob/d18b7aa8ba878354e5c348310230e652f7690f9c/skills/code-review/SKILL.md
License: Apache-2.0
Apache License
Version 2.0, January 2004
http://www.apache.org/licenses/
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
1. Definitions.
"License" shall mean the terms and conditions for use, reproduction,
and distribution as defined by Sections 1 through 9 of this document.
"Licensor" shall mean the copyright owner or entity authorized by
the copyright owner that is granting the License.
"Legal Entity" shall mean the union of the acting entity and all
other entities that control, are controlled by, or are under common
control with that entity. For the purposes of this definition,
"control" means (i) the power, direct or indirect, to cause the
direction or management of such entity, whether by contract or
otherwise, or (ii) ownership of fifty percent (50%) or more of the
outstanding shares, or (iii) beneficial ownership of such entity.
"You" (or "Your") shall mean an individual or Legal Entity
exercising permissions granted by this License.
"Source" form shall mean the preferred form for making modifications,
including but not limited to software source code, documentation
source, and configuration files.
"Object" form shall mean any form resulting from mechanical
transformation or translation of a Source form, including but
not limited to compiled object code, generated documentation,
and conversions to other media types.
"Work" shall mean the work of authorship, whether in Source or
Object form, made available under the License, as indicated by a
copyright notice that is included in or attached to the work
(an example is provided in the Appendix below).
"Derivative Works" shall mean any work, whether in Source or Object
form, that is based on (or derived from) the Work and for which the
editorial revisions, annotations, elaborations, or other modifications
represent, as a whole, an original work of authorship. For the purposes
of this License, Derivative Works shall not include works that remain
separable from, or merely link (or bind by name) to the interfaces of,
the Work and Derivative Works thereof.
"Contribution" shall mean any work of authorship, including
the original version of the Work and any modifications or additions
to that Work or Derivative Works thereof, that is intentionally
submitted to the Licensor for inclusion in the Work by the copyright owner
or by an individual or Legal Entity authorized to submit on behalf of
the copyright owner. For the purposes of this definition, "submitted"
means any form of electronic, verbal, or written communication sent
to the Licensor or its representatives, including but not limited to
communication on electronic mailing lists, source code control systems,
and issue tracking systems that are managed by, or on behalf of, the
Licensor for the purpose of discussing and improving the Work, but
excluding communication that is conspicuously marked or otherwise
designated in writing by the copyright owner as "Not a Contribution."
"Contributor" shall mean Licensor and any individual or Legal Entity
on behalf of whom a Contribution has been received by Licensor and
subsequently incorporated within the Work.
2. Grant of Copyright License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
copyright license to reproduce, prepare Derivative Works of,
publicly display, publicly perform, sublicense, and distribute the
Work and such Derivative Works in Source or Object form.
3. Grant of Patent License. Subject to the terms and conditions of
this License, each Contributor hereby grants to You a perpetual,
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
(except as stated in this section) patent license to make, have made,
use, offer to sell, sell, import, and otherwise transfer the Work,
where such license applies only to those patent claims licensable
by such Contributor that are necessarily infringed by their
Contribution(s) alone or by combination of their Contribution(s)
with the Work to which such Contribution(s) was submitted. If You
institute patent litigation against any entity (including a
cross-claim or counterclaim in a lawsuit) alleging that the Work
or a Contribution incorporated within the Work constitutes direct
or contributory patent infringement, then any patent licenses
granted to You under this License for that Work shall terminate
as of the date such litigation is filed.
4. Redistribution. You may reproduce and distribute copies of the
Work or Derivative Works thereof in any medium, with or without
modifications, and in Source or Object form, provided that You
meet the following conditions:
(a) You must give any other recipients of the Work or
Derivative Works a copy of this License; and
(b) You must cause any modified files to carry prominent notices
stating that You changed the files; and
(c) You must retain, in the Source form of any Derivative Works
that You distribute, all copyright, patent, trademark, and
attribution notices from the Source form of the Work,
excluding those notices that do not pertain to any part of
the Derivative Works; and
(d) If the Work includes a "NOTICE" text file as part of its
distribution, then any Derivative Works that You distribute must
include a readable copy of the attribution notices contained
within such NOTICE file, excluding those notices that do not
pertain to any part of the Derivative Works, in at least one
of the following places: within a NOTICE text file distributed
as part of the Derivative Works; within the Source form or
documentation, if provided along with the Derivative Works; or,
within a display generated by the Derivative Works, if and
wherever such third-party notices normally appear. The contents
of the NOTICE file are for informational purposes only and
do not modify the License. You may add Your own attribution
notices within Derivative Works that You distribute, alongside
or as an addendum to the NOTICE text from the Work, provided
that such additional attribution notices cannot be construed
as modifying the License.
You may add Your own copyright statement to Your modifications and
may provide additional or different license terms and conditions
for use, reproduction, or distribution of Your modifications, or
for any such Derivative Works as a whole, provided Your use,
reproduction, and distribution of the Work otherwise complies with
the conditions stated in this License.
5. Submission of Contributions. Unless You explicitly state otherwise,
any Contribution intentionally submitted for inclusion in the Work
by You to the Licensor shall be under the terms and conditions of
this License, without any additional terms or conditions.
Notwithstanding the above, nothing herein shall supersede or modify
the terms of any separate license agreement you may have executed
with Licensor regarding such Contributions.
6. Trademarks. This License does not grant permission to use the trade
names, trademarks, service marks, or product names of the Licensor,
except as required for reasonable and customary use in describing the
origin of the Work and reproducing the content of the NOTICE file.
7. Disclaimer of Warranty. Unless required by applicable law or
agreed to in writing, Licensor provides the Work (and each
Contributor provides its Contributions) on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied, including, without limitation, any warranties or conditions
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
PARTICULAR PURPOSE. You are solely responsible for determining the
appropriateness of using or redistributing the Work and assume any
risks associated with Your exercise of permissions under this License.
8. Limitation of Liability. In no event and under no legal theory,
whether in tort (including negligence), contract, or otherwise,
unless required by applicable law (such as deliberate and grossly
negligent acts) or agreed to in writing, shall any Contributor be
liable to You for damages, including any direct, indirect, special,
incidental, or consequential damages of any character arising as a
result of this License or out of the use or inability to use the
Work (including but not limited to damages for loss of goodwill,
work stoppage, computer failure or malfunction, or any and all
other commercial damages or losses), even if such Contributor
has been advised of the possibility of such damages.
9. Accepting Warranty or Additional Liability. While redistributing
the Work or Derivative Works thereof, You may choose to offer,
and charge a fee for, acceptance of support, warranty, indemnity,
or other liability obligations and/or rights consistent with this
License. However, in accepting such obligations, You may act only
on Your own behalf and on Your sole responsibility, not on behalf
of any other Contributor, and only if You agree to indemnify,
defend, and hold each Contributor harmless for any liability
incurred by, or claims asserted against, such Contributor by reason
of your accepting any such warranty or additional liability.
END OF TERMS AND CONDITIONS
Copyright 2025 Functional Software, Inc. dba Sentry
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
SKILL.md 본문입니다. 원문에서 참조하는 스크립트·보조 파일은 원본 패키지에 포함되어 있습니다.